search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

Add correction for eccentric pre SN orbits for SNflag2 #316

Closed mkruckow closed 3 months ago

mkruckow commented 4 months ago

It turned out, that the derivation of SNflag2 assumed a circular pre supernova orbit to simplify the equation. We use this flag to determine, whether a post SN orbit is bound or disrupted. Hence, we classified too many eccentric pre SN cases as disrupted in the SN. In a circular pre SN orbit, the correction factor would be 1, because it becomes Kepler's third law.

P.S.: I encountered the issue by making a check with 0 kick, where the two inequalities of the SNflag would become equal, hence no kick could hide the missing factor anymore. Maybe this would not mean that we had to many disrupted systems overall, but the kick range leading to disruptions was shifted surely.

mkruckow commented 4 months ago

Can you add a reference, with specific equations if possible, from were you got the correction factor?

I derived it myself. Thus the reference would be: my notes. We can may add it in the appendix or a section in the v2 paper.

astroJeff commented 3 months ago

@mkruckow can you post your notes? I'm having trouble deriving this check.