POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

step_disrupted does not update stellar/CO state #345

Open maxbriel opened 1 week ago

maxbriel commented 1 week ago

The detached step does not check for the physical accuracy of its components: step_end calls update_star_states to update the state of S1 to the correct type. It looks like the step_disrupted does not update the stellar state

Expected behaviour: S1_state is updated when entering step_disrupted.

Potential solution: Force a update_star_states of CO_type, when entering the disrupted/detached_step or in step_SN.

Binary Index S1 State S2 State S1 Mass S2 Mass Event State Orbital Period
532 H-rich_Core_H_burning H-rich_Core_H_burning 26.213338 24.474420 ZAMS detached 579.504315
532 stripped_He_Central_C_depletion H-rich_Core_He_burning 9.193318 13.938683 CC1 detached 1381.985011
532 BH H-rich_Core_He_burning 1.423424 13.938683 NaN disrupted NaN
532 BH stripped_He_Central_C_depletion 1.423424 9.171099 CC2 disrupted NaN
532 BH NS 1.423424 1.430361 NaN disrupted NaN
532 NS NS 1.423424 1.430361 END disrupted NaN