POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
30 stars 19 forks source link

Undefined binaries in flow: ('stripped_He_Central_He_depleted', 'H-rich_Core_H_burning', 'RLO1', 'oRLO1') #418

Open celiotine opened 2 weeks ago

celiotine commented 2 weeks ago

Binaries with the parameters ('stripped_He_Central_He_depleted', 'H-rich_Core_H_burning', 'RLO1', 'oRLO1') are failing because they are not handled in the flow. An example of one such binary:

ini_filepath_IF = "/projects/b1119/cliotine/pulsar_dev/pulsar_pops/runs/oct_2024/Sukhbold+16/grid_reruns_final/params.ini"
sim_kwargs_IF = simprop_kwargs_from_ini(ini_filepath_IF)
sim_prop_IF = SimulationProperties(**sim_kwargs_IF)
sim_prop_IF.load_steps(verbose=True)

star_1 = SingleStar(**{'mass':  6.30415516982906, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 3.19348803304828, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period': 585.7165771197014,'eccentricity': 0.0}, properties = sim_prop_IF)
binary_IF.evolve()
Screen Shot 2024-10-21 at 1 49 18 PM

This is happening when running with IF but not NN.

celiotine commented 2 weeks ago

Possibly related systems, though they are much rarer (these binaries also leave step_CE in RLO after step_HMS_HMS with an undefined state):

1) ('H-rich_Core_He_burning', 'H-rich_Shell_H_burning', 'RLO2', 'oRLO2')

star_1 = SingleStar(**{'mass':  6.629154054663811, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 5.643884766762587, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period': 3.5751166715461835,'eccentricity': 0.0}, properties = sim_prop_IF)
Screen Shot 2024-10-21 at 2 03 27 PM

2) ('H-rich_Central_He_depleted', 'H-rich_Core_H_burning', 'RLO1', 'oRLO1')

star_1 = SingleStar(**{'mass':  6.231467289002243, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 4.131398947001683, 'state': 'H-rich_Core_H_burning',
                'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0,  'state': 'detached',  'event': 'ZAMS', 
                        'orbital_period': 1091.020469084488, 'eccentricity': 0.0}, properties = sim_prop_IF)
Screen Shot 2024-10-21 at 2 09 13 PM
celiotine commented 1 week ago

Per discussion 10/24: It will be helpful to make a corner plot of the component masses and orbital periods for the He-rich stars RLOing onto H-rich stars. We should also get a more accurate estimate of their overall population frequency. We will most likely need a new grid to handle these systems. For now, these binaries can fail with a POSYDON error, but this is not the ideal long-term resolution.

For the other two binaries posted, there is a matching issue, because their primary stars leave CE as stripped_He stars but are matched to H-rich stars in the detached step. This should not happen.