Open celiotine opened 2 weeks ago
Possibly related systems, though they are much rarer (these binaries also leave step_CE in RLO after step_HMS_HMS with an undefined state):
1) ('H-rich_Core_He_burning', 'H-rich_Shell_H_burning', 'RLO2', 'oRLO2')
star_1 = SingleStar(**{'mass': 6.629154054663811, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 5.643884766762587, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0, 'state': 'detached', 'event': 'ZAMS',
'orbital_period': 3.5751166715461835,'eccentricity': 0.0}, properties = sim_prop_IF)
2) ('H-rich_Central_He_depleted', 'H-rich_Core_H_burning', 'RLO1', 'oRLO1')
star_1 = SingleStar(**{'mass': 6.231467289002243, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [None, None, None, None]})
star_2 = SingleStar(**{'mass': 4.131398947001683, 'state': 'H-rich_Core_H_burning',
'natal_kick_array': [None, None, None, None]})
binary_IF = BinaryStar(star_1, star_2, **{'time': 0.0, 'state': 'detached', 'event': 'ZAMS',
'orbital_period': 1091.020469084488, 'eccentricity': 0.0}, properties = sim_prop_IF)
Per discussion 10/24: It will be helpful to make a corner plot of the component masses and orbital periods for the He-rich stars RLOing onto H-rich stars. We should also get a more accurate estimate of their overall population frequency. We will most likely need a new grid to handle these systems. For now, these binaries can fail with a POSYDON error, but this is not the ideal long-term resolution.
For the other two binaries posted, there is a matching issue, because their primary stars leave CE as stripped_He stars but are matched to H-rich stars in the detached step. This should not happen.
Binaries with the parameters ('stripped_He_Central_He_depleted', 'H-rich_Core_H_burning', 'RLO1', 'oRLO1') are failing because they are not handled in the flow. An example of one such binary:
This is happening when running with IF but not NN.