Port of FS303 - wrong bit depth reported for OpenEXR file format

POV-Ray / povray

The Persistence of Vision Raytracer (POV-Ray)

https://www.povray.org/

GNU Affero General Public License v3.0

1.37k stars 282 forks source link

Port of FS303 - wrong bit depth reported for OpenEXR file format #211

Open wfpokorny opened 7 years ago

wfpokorny commented 7 years ago

http://bugs.povray.org/task/303

(Still true in the current master branch at commit: d6e8257 : Merge branch 'release/v3.7.1')

Details:

When using OpenEXR output file format, POV-Ray erroneously reports it as "24 bpp EXR" in the message output, while in fact it generates a 3×16 = 48 bpp file.

c-lipka commented 7 years ago

This is one of many cases where the code reporting the render settings is out of sync with the code that actually uses those settings.

In case of everything related to the output file format, I think this would best be tackled by encapsulating the file output code into a family of polymorphic classes (which is already on my mental ToDo list somewhere), and compute these derived values in methods of those classes.