search

POV-Ray / povray

The Persistence of Vision Raytracer: http://www.povray.org/
GNU Affero General Public License v3.0
1.35k stars 282 forks source link

Implement ini, command line override of thread stack size. #239

Closed wfpokorny closed 5 years ago

wfpokorny commented 7 years ago

Opening work item to override the POV_THREAD_STACK_SIZE macro setting via command line or ini file so as not to lose track of it.

Ref:

http://news.povray.org/povray.beta-test/thread/%3C58a9e177%241%40news.povray.org%3E/

wfpokorny commented 5 years ago

Recently c-lipka requested testing for stack size issues in the povray.macintosh and povray.beta-test newsgroups.

http://news.povray.org/povray.macintosh/message/%3C5c675c0e%241%40news.povray.org%3E/#%3C5c675c0e%241%40news.povray.org%3E

and

http://news.povray.org/povray.beta-test/message/%3C5c675cff%241%40news.povray.org%3E/#%3C5c675cff%241%40news.povray.org%3E

Attaching zip from Thorsten (ThH) from the work (#231 and #235) which itself includes a number of test cases some of which (3rd ?) still failed for the default settings let alone the smaller one suggested by Christoph for testing. Uncomment the lines at the bottom one by one to run each.

attractors.zip

NOTE! After unzipping the file the attractors.pov file needs to be updated so the include reads:

include "attractors.inc"

Further, we should remember this issue should further related code updates be made.

wfpokorny commented 5 years ago

Christoph eliminated the need for POV_THREAD_STACK_SIZE altogether in the v38 master branch with the changes mentioned in the comment just prior.