POptUS / IBCDFO

Interpolation-Based Composite Derivative-Free Optimization
Other
7 stars 2 forks source link

2024 TODOs #122

Open jared321 opened 10 months ago

jared321 commented 10 months ago
jared321 commented 9 months ago

@jmlarson1 I see that you now have a GitHub action for running black on updates to pull requests. If all the python files pass flake8, then why do they also need to make black happy?

jmlarson1 commented 9 months ago

Black is certainly more restrictive than flake8, and I'm fine with relaxing the running of black for PRs. I do think it's nice to know/see. (We can pull in without black passing, though.)

jared321 commented 9 months ago

Does that mean that the PR will show a failure with the red "X" and we would just ignore that after checking that the failure is only due to the black CI action? If so, do we want to have caveats tied to the interpretation of CI results?

My two cents is that black is too restrictive. It wouldn't be an issue except that I don't like the idea of a tool changing my code unless I can be certain that I can check its changes, and black can make that more difficult because it can make many "insignificant" changes. What if there are method developers like me that don't want to adhere to/use black?