search

PPC64 / hhvm

A virtual machine designed for executing programs written in Hack and PHP.
http://hhvm.com
Other
4 stars 3 forks source link

Pull fixes for facebook/hhvm#7133 #144

Closed daxtens closed 8 years ago

daxtens commented 8 years ago

In https://github.com/facebook/hhvm/issues/7133, upstream makes a fix that improves HHVM performance for some string functions.

racardoso commented 8 years ago

That's very nice. We often merge upstream every Thursday. But in this case i will update today because i'm running oss-performance benchmarks. Thanks.

racardoso commented 8 years ago

Closed via 9530837 However, i don't see any performance increase or decrease on oss-performance.

daxtens commented 8 years ago

Ok, I wasn't sure when you normally merged or if you had a regular schedule

There doesn't seem to be any performance win on most macrobenchmarks but there are for microbenchmarks.

Thanks!

On Tue, Jul 12, 2016 at 4:29 AM, Rogerio Alves notifications@github.com wrote:

Closed #144 https://github.com/PPC64/hhvm/issues/144.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PPC64/hhvm/issues/144#event-719121822, or mute the thread https://github.com/notifications/unsubscribe/ADJ5BSn3QXFXarhopgDmBY4euVNyiNZvks5qUoumgaJpZM4JI9t_ .

racardoso commented 8 years ago

@daxtens Np. By the way, as soon as possible, those merges will be made automatically in a daily basis we do this. Now we do this manually that's why we normally do that once a week. But if you saw something upstream that caught your attention please let us know about it and feel free to open tasks like this if you want. Thanks.