search

PPC64 / hhvm

A virtual machine designed for executing programs written in Hack and PHP.
http://hhvm.com
Other
4 stars 3 forks source link

Refactor SF optimization for PPC64 #149

Closed gut closed 8 years ago

gut commented 8 years ago

Based on Daniel's pull request: https://github.com/PPC64/hhvm/pull/143

Refactor it to use a new optimization phase, similar to what is done on this simplify step: https://github.com/facebook/hhvm/commit/fa442471676c9550691c28fe31c9fee2edda0a05

Please avoid changes on hphp/runtime/vm/jit/vasm-instr.h. That's probably unwelcome by HHVM community.

After that, create a PR please

daxtens commented 8 years ago

I don't have time to do this myself, but if there's any help I can offer please let me know.

On Wed, Aug 31, 2016 at 2:31 AM, Gustavo Serra Scalet < notifications@github.com> wrote:

Based on Daniel's pull request: #143 https://github.com/PPC64/hhvm/pull/143

Refactor it to use a new optimization phase, similar to what is done on this simplify step: facebook@fa44247 https://github.com/facebook/hhvm/commit/fa442471676c9550691c28fe31c9fee2edda0a05

Please avoid changes on hphp/runtime/vm/jit/vasm-instr.h. That's probably unwelcome by HHVM community.

After that, create a PR please

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PPC64/hhvm/issues/149, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJ5BQDOCL79KaWiieFQxRmBIpFeGvLLks5qlFrSgaJpZM4JwuOh .

brunoalr commented 8 years ago

@daxtens thanks for offering help! I'll ping you when needed.

lbianc commented 8 years ago

PR sent: https://github.com/facebook/hhvm/pull/7326.