PPPLDeepLearning / plasma-python

PPPL deep learning disruption prediction package
http://tigress-web.princeton.edu/~alexeys/docs-web/html/
79 stars 43 forks source link

Weighting factor for positive examples (conf['data']['positive_example_penalty']) only works for 'maxhinge' target #53

Open felker opened 4 years ago

felker commented 4 years ago

The only time in which positive_example_penalty appears in the codebase is in: https://github.com/PPPLDeepLearning/plasma-python/blob/c82ba61e339882a5af10b1052edc0348e16119f4/plasma/conf_parser.py#L86-L102 which is loaded only for an unused method in the MaxHingeTarget class, noted here: https://github.com/PPPLDeepLearning/plasma-python/blob/7986f468e43a56a5ae845dd1b88cf9fca048ac5a/plasma/models/targets.py#L153

Need to extend it to the other target functions, remove it as a parameter, or document this more thoroughly.

Not as important for DIII-D datasets as it is for our JET datasets (for which the non-/disruptive classes are more imbalanced).