PQYPLZXHGF / drawshield

Drawing heraldic shields from blazons - Automatically exported from:
https://code.google.com/archive/p/drawshield/
Apache License 2.0
1 stars 2 forks source link

Give tincture elements explicit names, e.g. tincture1, tincture2 etc. #199

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This will remove the dependence on the ordering of tinctures beneath its parent 
element to indicate which is which, and also allow tincture elements to be 
mixed in with modifiers. This gives more flexibility and allows the removal of 
the "mods" array that gets passed around a lot before finally being 
append-child fixed onto the parent element. When looking for tinctures can just 
check first 8 characters of element name.

Original issue reported on code.google.com by KarlWilcox36@gmail.com on 26 Aug 2010 at 6:01

GoogleCodeExporter commented 9 years ago
Turns out to be easier to give each tincture element an 'index' attribute 
instead. Done, no externally visible change but gives more flexibility in the 
arrangement of the blazonML data and removes positional dependency from the 
schema and code (e.g. modifier elements can be freely mixed in with tincture 
nodes).

Original comment by KarlWilcox36@gmail.com on 24 May 2011 at 10:09