PR2 / linux_networking

2 stars 8 forks source link

ROS-melodic .debs for network_monitor_udp incomplete #3

Closed bk-mtg closed 4 years ago

bk-mtg commented 4 years ago

The ROS melodic install of this package is missing most of the useful files, including the node python scripts, python libraries, and standalone binaries. Additionally, changes to the core ROS python libraries over time meant that some of the python code wouldn't run.

This PR makes the following changes, which (on my test system at least) results in usable python scripts, and generates .deb packages that include all the desired output files:

v4hn commented 4 years ago

Thanks for addressing the feedback! Looks good now.

bk-mtg commented 4 years ago

Thank you! Any idea how soon we might see a release with this so as to get the updated binaries in the package system?

v4hn commented 4 years ago

@k-okada released the PR2 packages in the past for kinetic/melodic. I will leave the release to him. But I would say his availability is the only constraint on an immediate release.

k-okada commented 4 years ago

Ok, done https://github.com/ros/rosdistro/pull/22917

2019年11月8日(金) 15:44 Michael Görner notifications@github.com:

@k-okada https://github.com/k-okada released the PR2 packages in the past for kinetic/melodic. I will leave the release to him. But I would say his availability is the only constraint on an immediate release.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/PR2/linux_networking/pull/3?email_source=notifications&email_token=AADYNXDJGWNLH7BWIKUVSHTQSUDDBA5CNFSM4JJ53LB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO4XFY#issuecomment-551406487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNXDCDWV4RNL52RNCIXDQSUDDBANCNFSM4JJ53LBQ .

--

◉ Kei Okada