search

PR2 / linux_networking

2 stars 8 forks source link

build/testing fixes for noetic compatibility #5

Closed davefeilseifer closed 3 years ago

davefeilseifer commented 3 years ago

updated python scripts and build dependencies to allow for building under noetic (and melodic) using python3.

passing prerelease test:

generate_prerelease_script.py https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml noetic default ubuntu focal amd64 --custom-repo linux_networking__custom-2:git:https://github.com/PR2-prime/linux_networking.git:melodic-devel --level 0 --output-dir ./

v4hn commented 3 years ago

Thanks!

k-okada commented 3 years ago

@v4hn @davefeilseifer Sorry for slow responce and thank you for contribution. Are you sure that this PR works on noetic?

You put <run_depend condition="$ROS_PYTHON_VERSION == 3">python3-twisted</run_depend> that is nice, but I think you need <package format="3".. May be we'd beter to run travis before we merge PR....https://github.com/PR2/linux_networking/pull/6

Traceback (most recent call last):
  File "/usr/bin/catkin", line 11, in <module>
    load_entry_point('catkin-tools==0.5.0', 'console_scripts', 'catkin')()
  File "/usr/lib/python3/dist-packages/catkin_tools/commands/catkin.py", line 272, in main
    catkin_main(sysargs)
  File "/usr/lib/python3/dist-packages/catkin_tools/commands/catkin.py", line 267, in catkin_main
    sys.exit(args.main(args) or 0)
  File "/usr/lib/python3/dist-packages/catkin_tools/verbs/catkin_build/cli.py", line 404, in main
    return build_isolated_workspace(
  File "/usr/lib/python3/dist-packages/catkin_tools/verbs/catkin_build/build.py", line 296, in build_isolated_workspace
    workspace_packages = find_packages(context.source_space_abs, exclude_subspaces=True, warnings=[])
  File "/usr/lib/python3/dist-packages/catkin_pkg/packages.py", line 87, in find_packages
    packages = find_packages_allowing_duplicates(basepath, exclude_paths=exclude_paths, exclude_subspaces=exclude_subspaces, warnings=warnings)
  File "/usr/lib/python3/dist-packages/catkin_pkg/packages.py", line 147, in find_packages_allowing_duplicates
    parsed_package = parse_package_string(
  File "/usr/lib/python3/dist-packages/catkin_pkg/package.py", line 598, in parse_package_string
    raise InvalidPackage('The manifest contains invalid XML:\n%s' % ex, filename)
catkin_pkg.package.InvalidPackage: Error(s) in package '/home/user/ws_pr2/src/linux_networking/multi_interface_roam/package.xml':
The manifest contains invalid XML: