search

PR2 / pr2_apps

15 stars 24 forks source link

remove GetKinematicSolverInfo #35

Closed k-okada closed 6 years ago

k-okada commented 6 years ago

GetKinematicSolverInfo.srv has been removed from moveit_msgs by https://github.com/ros-planning/moveit_msgs/issues/3, since I'm not sure what is the best way to re-write code without this service, but to write the list of joint names directory

v4hn commented 6 years ago

The previous code already listed the joints more or less hard-coded:

https://github.com/k-okada/pr2_apps/blob/e4dc55d7c450910e884207e8a177553dbf0ba7ff/pr2_teleop_general/src/pr2_teleop_general_commander.cpp#L669

So I don't think it is particularly bad to hard-code them in your place too. Of course it would be better to do this just once in a global vector...