search

PR2 / pr2_apps

15 stars 24 forks source link

add test for roslaunch_add_file_check #40

Closed k-okada closed 4 years ago

k-okada commented 5 years ago

add

# test                                                                          
if(CATKIN_ENABLE_TESTING)
  find_package(roslaunch REQUIRED)
  find_package(rostest REQUIRED)
  file(GLOB LAUNCH_FILES launch/*.launch)
  foreach(LAUNCH_FILE ${LAUNCH_FILES})
    message(STATUS "Testing ${LAUNCH_FILE}")
    roslaunch_add_file_check(${LAUNCH_FILE})
  endforeach()
endif()

to all CMakeLists.txt

v4hn commented 5 years ago

Why would you merge this with #38?

Also, CI timed out without output. I never looked into what causes these timeouts, do you have some experience with them or do you just retrigger CI to resolve them?

k-okada commented 5 years ago

Why would you merge this with #38?

40, whcih try to check launch files over all packages in pr2_apps repository, never pass without #38, so we need to include #38 in this PR

I never looked into what causes these timeouts, do you have some experience with them or do you just retrigger CI to resolve them?

Sometimes apt-get update or apt-get install stuck for some reason, and usually retriggering fixed the problem..