search

PR2 / pr2_common

45 stars 79 forks source link

Fixed more missing / incorrect URDF elements. #220

Closed danepowell closed 11 years ago

danepowell commented 11 years ago

Some of these are just wrapping up elements that I missed in https://github.com/PR2/pr2_common/pull/219 . The incorrect focal_lengths are clearly just due to rounding errors in how Gazebo calculates focal lengths- not a big deal but they throw a bunch of warnings.

davetcoleman commented 11 years ago

I have tested this PR by launching it and it seems to work on my machine

ahendrix commented 11 years ago

It still smells funny. Why are we using the depth camera plugin to simulate a simple color camera?

danepowell commented 11 years ago

It looks like it was originally a plain old camera, but got changed to a depth camera two years ago with this commit - "for testing": https://github.com/PR2/pr2_common/commit/4c071dd1fe7e1e1c2751933a170ad0589bd9dfa8#pr2_description/urdf/sensors/wge100_camera.gazebo.xacro

I don't know what was being tested, but it probably should have been changed back afterwards.

ahendrix commented 11 years ago

Can you change the wge100 plugin back to a regular camera and update this pull request?