search

PR2 / pr2_common

45 stars 79 forks source link

Change default branch to indigo #236

Closed davetcoleman closed 9 years ago

garaemon commented 9 years ago

Why do we need different branch from hydro? I hope we can use same branch...

TheDash commented 9 years ago

Different distributions. Groovy had its own branch. Hydro does. Why not one for indigo devel?

garaemon commented 9 years ago

I think indigo works well with hydro codes without any changes. If it's true in pr2_common repository, I think we don't need to have indigo-branch.

However, I agree with that it is reasonable to have different branches for each distribution. But it increases effort of maintainers...

TheDash commented 9 years ago

It's okay. I can deal with creating Indigo branches. If there is a bug that is only in Indigo, and someone fix it, but the release repository is pointing to Hydro, and then it breaks Hydro, then there will be problems.

Otherwise, any pull requests to Hydro branch will be forced to test against Hydro and Indigo. And logically, that would mean Hydro code would have to compile on 14.04 systems, and Indigo code against 12.04 systems..

garaemon commented 9 years ago

Great! It sounds perfect!

davetcoleman commented 9 years ago
  1. There was already a indigo branch, it just wasn't default
  2. I tried compiling this repo in indigo today and it was missing dependencies (ivcon and others)
  3. urdfdom changed between distros so requires a split in branches
TheDash commented 9 years ago

This branch compiles and the stuff it requires has been released. Just has to be installed via source ATM. I tested it last Tuesday. On Jan 20, 2015 4:52 AM, "Dave Coleman" notifications@github.com wrote:

  1. There was already a indigo branch, it just wasn't default
  2. I tried compiling this repo in indigo today and it was missing dependencies (ivcon and others)

— Reply to this email directly or view it on GitHub https://github.com/PR2/pr2_common/issues/236#issuecomment-70611837.