Search for ivcon/convex_decomposition commands

[cottsay]

If the environment where ivcon/convex_decomposition is built or installed hasn't been sourced, the binaries aren't in the PATH, and therefore aren't located.

Right now, pr2_decomposition builds fail when following the "Source" installation instructions on the ROS wiki because no ROS environments have had "setup.bash" sourced yet.

Thanks,

--scott

[TheDash]

If you have ivcon and convex_decomposition installed, these errors will go away.

[TheDash]

I believe this is a dependency issue and not a sourcing issue, correct me if I'm wrong though.

[cottsay]

It is both. Right now, these dependencies are supplied by ROS packages, not by the system. When you're building using the "source" installation instructions [1], the ROS environment isn't necessarily "sourced" when you're building. In this case ivcon and convex_decomposition aren't in PATH at all until you "source" the appropriate setup.bash.

So as long as you have "sourced" the ROS environment where ivon and convex_decomposition are built/installed, this isn't a problem (which is why this doesn't break on the buildfarm). But when you're building everything at once for the first time, there isn't anything to source.

As a repro, just try following the official directions for a "source" install [1]. This bug should be present on all platforms.

Using find_program will first look for the binaries in the given paths, and will fall back to searching PATH (which is obviously where the binaries must be right now).

I did a desktop-full build on Fedora this weekend, and this was the only build break across Indigo and Jade.

[1] http://wiki.ros.org/jade/Installation/Source

[IanMHoffman]

This pull fixed my problems thanks cottsay!

[TheDash]

Thanks for the clarification. I'll merge it.