search

PR2 / pr2_common

46 stars 78 forks source link

cleanup rviz errors #278

Closed v4hn closed 5 years ago

v4hn commented 5 years ago

This converts a number of texture files and the kinect2 mesh file to different formats to finally get rid of a number of well-known errors every time you loadup RViz with the model loaded.

@k-okada I guess your group also has an interested to see this merged :sunglasses: .

The commits should also be merged into melodic-devel, but we are "still" stuck with kinetic-devel for now.

Fixes #257 .

v4hn commented 5 years ago

The larger (first) commit 6aa7e59 was generated automatically by converting all *.tif files to .png and replacing all file references to such files appropriately.

For e78d8df I opened and exported the old mesh via meshlab.

k-okada commented 5 years ago

@v4hn since we already release kinetic package from melodic-devel branch, I think this patch should target to melodic-devel branch and release into kinetic/melodic. https://github.com/ros/rosdistro/pull/21018/files https://github.com/PR2/pr2_common/network

v4hn commented 5 years ago

True, somehow we missed that as we use a custom branch on our own system. I just rebased on top of melodic-devel. Please review and merge if this is ok with you.