search

PR2 / pr2_common

45 stars 78 forks source link

Change DiagnosticValue to become KeyValue (ros ticket #1903) #49

Closed ahendrix closed 11 years ago

ahendrix commented 11 years ago

string key string value

replace DiagnosticString too

trac data:

ahendrix commented 11 years ago

[blaise] Done.

ahendrix commented 11 years ago

[watts] Did we seriously get rid of DiagnosticStrings? Diagnostic_updater is broken, and it's looking for strings I believe.

ahendrix commented 11 years ago

[tfoote] yeah, remember we chose to use just key value in the meeting. both strings so that you can format your number however you want.

I've already fixed diagnostic updater and am working my way up the stack.

ahendrix commented 11 years ago

[tfoote] i've made a bunch of progress, with this.

The decision was to make everything KeyValue string string. I've fixed up through hokuyo node.

ahendrix commented 11 years ago

[blaise] Tully, are you still working on this or do you want me to take over? And I apologize for the mess. I was trying to get other things done and didn't think back to why were making this change in the first place.

ahendrix commented 11 years ago

[blaise] Tully, I would like to take this over again. Let me know when you are fully checked in.

ahendrix commented 11 years ago

[tfoote] i don't have any local changes, i've been incrementally committing to try to fix the build

feel free to go ahead.

Sorry about the incomplete ticket writeup. I wrote it down enough for me to fill out, but forgot to check that i'd completed the ticket before handing it off to you

ahendrix commented 11 years ago

[blaise] OK, I'm going to fix the things that are currently broken, and then at a more leisurely rate fix the things that you updated.

ahendrix commented 11 years ago

[tfoote] moved, created new ticket to track the fact that some things are broken #2339

ahendrix commented 11 years ago

Milestone common_msgs-M3 deleted