search

PR2 / pr2_controllers

The controllers that run in realtime on the PR2 and supporting packages.
46 stars 34 forks source link

Joint Position and Velocity controllers startup fix #376

Closed goretkin closed 2 years ago

goretkin commented 9 years ago

Fixes https://github.com/PR2/pr2_controllers/issues/374

goretkin commented 9 years ago

Sorry, I meant to merge into groovy-devel. I don't know how to change it. Perhaps I need to close this PR and open a new one.

I also wanted to show that this fix is what is already done in other controllers, for example: https://github.com/PR2/pr2_controllers/blob/hydro-devel/robot_mechanism_controllers/src/joint_trajectory_action_controller.cpp#L313 They also use the starting function to set the last_time_.

goretkin commented 6 years ago

@k-okada Hi, what does the question tag mean? Are you interested in maintaining this package?

k-okada commented 6 years ago

I'm released these package as a part of our Orphaned Maintanair Project. so not so much interested in 'maintaining' this package, sorry for that.

I'm not sure if we should include this PR, so waiting for other users feedback. Also could you please rebase this on kinetic-devel branch?

c.f. https://github.com/PR2/rqt_pr2_dashboard/pull/20#issuecomment-365657928

v4hn commented 2 years ago

Replaced by #404 (error code: merge event not found -.-")