search

PR2 / pr2_controllers

The controllers that run in realtime on the PR2 and supporting packages.
46 stars 34 forks source link

Remove actionlib typedefs defined upstream #396

Closed sloretz closed 5 years ago

sloretz commented 5 years ago

This is needed to build successfully since https://github.com/ros/actionlib/pull/145 was merged. Long term, it looks like RTServerGoalHandle could be replaced with a dependency on ros-controls/realtime_tools

bmagyar commented 5 years ago

@k-okada do you have merge permissions here? Could you please help us out?

k-okada commented 5 years ago

@bmagyar @sloretz I have permissions, but Travis said this breaks the build. Can we add if ACTIONLIB_Version >= 1.12.0 or if not defined to keep backcompatibility? https://travis-ci.com/PR2/pr2_controllers/jobs/223258204

[ 88%] Building CXX object CMakeFiles/robot_mechanism_controllers.dir/src/joint_trajectory_action_controller.cpp.o
In file included from /tmp/ws/src/pr2_controllers/robot_mechanism_controllers/src/joint_trajectory_action_controller.cpp:37:0:
/tmp/ws/src/pr2_controllers/robot_mechanism_controllers/include/robot_mechanism_controllers/joint_trajectory_action_controller.h:81:3: error: ‘ResultPtr’ does not name a type; did you mean ‘Result’?
   ResultPtr preallocated_result_;  // Preallocated so it can be used in realtime
   ^~~~~~~~~
   Result
/tmp/ws/src/pr2_controllers/robot_mechanism_controllers/include/robot_mechanism_controllers/joint_trajectory_action_controller.h:82:3: error: ‘FeedbackPtr’ does not name a type; did you mean ‘Feedback’?
   FeedbackPtr preallocated_feedback_;
   ^~~~~~~~~~~
   Feedback
/tmp/ws/src/pr2_controllers/robot_mechanism_controllers/include/robot_mechanism_controllers/joint_trajectory_action_controller.h:84:43: error: ‘ResultPtr’ does not name a type; did you mean ‘Result’?
k-okada commented 5 years ago

@sloretz @bmagyar released new version on melodic https://github.com/ros/rosdistro/pull/21970

sloretz commented 5 years ago

Thanks @k-okada !