Move pr2_mechanism_diagnostics into pr2_mechanism stack (ros ticket #4286)

PR2 / pr2_mechanism

Infrastructure to control the PR2 robot in a hard realtime control loop.

Other

29 stars 27 forks source link

Move pr2_mechanism_diagnostics into pr2_mechanism stack (ros ticket #4286) #277

Closed ahendrix closed 11 years ago

ahendrix commented 11 years ago

This should be moved into pr2_mechanism and replace the existing joints_to_diags and controllers_to_diags scripts. It is faster and has fixed a lot of bugs.

https://code.ros.org/svn/wg-ros-pkg/trunk/sandbox/pr2_mechanism_diagnostics

trac data:

Owner: wim
Reporter: watts
Reported at: Thu May 6 19:25:30 2010
URL: https://code.ros.org/trac/wg-ros-pkg/ticket/4286

ahendrix commented 11 years ago

[wim] Modifications made:

add message when no controllers are loaded
copy timout policy and strings from previous diagnostics code
fix segfault when erasing elements from map while iterating through map

ahendrix commented 11 years ago

[wim] Moved package into pr2_mechanism trunk, and start by default.

Removed old diagnostics scripts.

ahendrix commented 11 years ago

[watts] Thanks for fixing the segfault, that was pretty dumb.

I added #4328 to talk about the controller warnings.

Should we restore the old scripts and deprecate them? I think that's an easy way to go. We can have them rospy.logwarn() at startup about deprecation. Alternatively, we could make a case for not deprecating them, since the launch file is the only thing that was supported.

Thanks a lot, I think this will really help me out. I will make sure this passes doc review when the time comes.

ahendrix commented 11 years ago

[wim] Yes, I think we don't need a deprecation, because we simply replaced the python scripts with new code that has the same functionality, so when you run the launch file, you'll get the same functionality.