search

PR2 / pr2_pbd

Programming by demonstration for the PR2
12 stars 22 forks source link

Landmark registration algorithm is wrong #21

Open mayacakmak opened 10 years ago

mayacakmak commented 10 years ago

When there are two similar objects in the learned action, sometimes they end up being registered to the same object during execution. This can be avoided by implementing the registration algorithm as described in the RSS paper.

mayacakmak commented 10 years ago

sonyaa has a correct implementation.

mbforbes commented 10 years ago

This existed in the system previously, and was not introduced by me, correct?

mayacakmak commented 10 years ago

yes correct! sonyaa fixed it to do the RSS experiments but it's in her fork.

mbforbes commented 10 years ago

Can we assign @sonyaa to implement this? :-)

mayacakmak commented 10 years ago

This is not urgent, it's the bug we've had for the longest time so I know exactly what not to do during demos. But I put it in so we remember to fix it at some point.