PRBonn / MaskPLS

Mask-Based Panoptic LiDAR Segmentation for Autonomous Driving, RA-L, 2023
MIT License
54 stars 7 forks source link

The self.level_embed paramter is never used #13

Closed timmeinhardt closed 1 year ago

timmeinhardt commented 1 year ago

Your MaskedTransformerDecoder never applies the level encoding during the forward pass. Was this intentionally?

rmarcuzzi commented 1 year ago

Hi! We don't use it, we just forgot to remove it from the code.

timmeinhardt commented 1 year ago

Did you ablate whether adding/removing the level encoding has an effect on the performance?

rmarcuzzi commented 1 year ago

In our early experiments, adding it didn't change the performance but we didn't check in the final model.