PRBonn / OverlapNet

OverlapNet - Loop Closing for 3D LiDAR-based SLAM (chen2020rss)
MIT License
662 stars 115 forks source link

Some confusion about real overlap calculation #30

Closed ZYJ0409 closed 2 years ago

ZYJ0409 commented 2 years ago

Dear author I had some problems running your code with the overlap truth calculation. In the 00 sequence, frame 0 and frame 4449 are the same region, but their true overlap is only 0.14.

微信图片_20220411160408 微信图片_20220411160444

I look forward to your reply. Thank you

Chen-Xieyuanli commented 2 years ago

Hey @ZYJ0409, thanks for using our code!

In my case, it's more than 80. Which code are you using? You may double check the poses you are using.

Screenshot from 2022-04-11 11-40-22

ZYJ0409 commented 2 years ago

Dear author Thank you for your reply. I refer to 'com_overlap_yaw ()' in your code. I enter 'current_POSES' in frame 0 (white) and 'reference_IDx' in frame 4449 (blue). This is the pose of my two frames, but the overlap area of my output is only 0.14. How do you solve the error caused by the scale drift of kitti dataset?

微信图片_白色 微信图片_蓝色 微信图片_当前帧 微信图片_检测帧

Looking forward to your reply.

Chen-Xieyuanli commented 2 years ago

I think the error comes from the poses. Are you using the ground truth poses? They are in the camera coordinate systems and you need to first convert them into the LiDAR coordinate system.

ZYJ0409 commented 2 years ago

Dear author I'm sorry that's my problem. I didn't express myself clearly. This is indeed the camera pose, but your code has been converted in "demo4_gen_gt_files", I have taken this into account, but the result is still very low

微信图片_convert
ZYJ0409 commented 2 years ago

This is our transformation method. If possible, could you please provide your algorithm or source code? Thank you very much! 微信图片_20220412092437

Chen-Xieyuanli commented 2 years ago

How did you generate the poses? They seem not accurate and not the ground truth poses.

ZYJ0409 commented 2 years ago

Dear author I downloaded them from the Internet, Can you provide a link to download the ground truth poses? (the best is 'baidu cloud’),thank you very much, Your reply was very helpful to us!

Chen-Xieyuanli commented 2 years ago

You could try these two together with our code. calib.txt poses.txt

ZYJ0409 commented 2 years ago

Thank you very much for your patient help. There is something wrong with our data. Wish you a happy life and smooth work!

Chen-Xieyuanli commented 2 years ago

I'm glad that the problem is solved! I will then close this issue.

I'll appreciate it if you could star our repo to let more people see it if you find our code and answers helpful.