PRBonn / kinematic-icp

A LiDAR odometry pipeline for wheeled mobile robots
https://www.ipb.uni-bonn.de/wp-content/papercite-data/pdf/kissteam2025icra.pdf
MIT License
199 stars 22 forks source link

Fixing ROS launch system #8

Closed tizianoGuadagnino closed 1 month ago

tizianoGuadagnino commented 1 month ago

There were some last-minute changes in the launch system used in the project before the open-source release. In the process the rviz node got removed from the online_node launch, and we didn't realize it because we assumed the default value of the visualize flag was set to false, while it was true. This PR fixes both issues:

  1. Re-introduce the Rviz node into the online_node launch.
  2. Set the visualize flag to false by default
  3. Remove legacy (project is open-source from 5 minutes but ok) parameter bag_filenames