PRBonn / phenobench-baselines

Baselines of the PhenoBench Dataset
https://www.phenobench.org
22 stars 4 forks source link

Feedback on Mask2Former baseline code #1

Closed RGring closed 9 months ago

RGring commented 1 year ago

Hi, Thanks a lot for providing all these baselines, weights and masks. I am really impressed by the structured repositories regarding the phenobench dataset.

I just wanted to give some feedback on running the Mask2Former baseline code. Instruction on how to convert the data in the format expected by Detectron2 is missing.

Note, that by default the folders and *.json files are named {plants/leaves}_panoptic{train/val}. However, in Mask2Former you use phenorob{plants/leaves}_panoptic{train/val}.

I suggest to add "make data" in the Makefile to make that process easy.

Hope my input helps to resolve minor bugs!

jbehley commented 1 year ago

Thanks @RGring for the suggestions and for trying out the code, we will look into this and provide additional code to make it clearer.

As you might have noticed, the different baselines were implemented/run by different people and I pushed to get it out; maybe a little bit to rushed so that it's still a bit a "work-in-progress". hope that we can resolve all issues quickly.

markselias commented 9 months ago

Sorry for the delay, but we added the data preprocessing steps to the instructions now. Thanks for pointing it out @RGring !