question about why disable batch_shuffle_ddp

PRBonn / segcontrast

MIT License

96 stars 13 forks source link

question about why disable batch_shuffle_ddp #7

Closed jackmsye closed 2 years ago

jackmsye commented 2 years ago

hello, thx for your great work. I have a question why you disable ddp shuffle. See https://github.com/PRBonn/segcontrast/blob/main/models/moco.py#L306

nuneslu commented 2 years ago

I have used as a basis the moco implementation from DepthContrast and in their implementation they also disable it (see issue). In my case, I have implemented and tested but there was no difference, so I keep it disabled to keep consistent with their implementation.