merge but some issues

[colin-combe]

hi suresh, this pull request is to try to synch us up again.

It changes the id of upload to an int rather than a uuid, which is how i had it now.

It re-adds some changes that got overwritten:

• Adds threshold column to spectrumidentificationprotocol and
• adds spectrumidentificationlist ref to spectrumidentification

I have some questions about all the JSON columns.

But main problem is that now I cant create the DB schema by running create_db_schema.py? It says: AttributeError: module 'app.models.base' has no attribute 'metadata'

@sureshhewabi @ypriverol

[colin-combe]

But main problem is that now I cant create the DB schema by running create_db_schema.py? It says: AttributeError: module 'app.models.base' has no attribute 'metadata'

Seems like that was caused by having this line: https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/dev/create_db_schema.py#L32 commented out by mistake.

(@sureshhewabi @ypriverol )

[colin-combe]

Seems like that was caused by having this line: https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/dev/create_db_schema.py#L32 commented out by mistake.

Uh, no - it didn't crash but it also didn't create the tables...

[sureshhewabi]

Seems like that was caused by having this line: https://github.com/Rappsilber-Laboratory/xi-mzidentml-converter/blob/dev/create_db_schema.py#L32 commented out by mistake.

Uh, no - it didn't crash but it also didn't create the tables...

@colin-combe Sorry it should beBase.metadata.create_all(engine). I corrected it and now it should work

[colin-combe]

Cool - I'll test it before I call you

[colin-combe]

yes, i can create the tables now