search

PRIDE-Archive / xi-mzidentml-converter

Apache License 2.0
0 stars 0 forks source link

xiview is not working #49

Closed ypriverol closed 5 months ago

ypriverol commented 5 months ago

@sureshhewabi we are probably having some issues with the xiview now, because it is not working https://www.ebi.ac.uk/pride/archive/xiview/network.html?project=PXD035519

sureshhewabi commented 5 months ago

@ypriverol URL needs to be changed in Pride Web crosslinking page visualise button URL:

From https://www.ebi.ac.uk/pride/archive/xiview/ws/data/get_xiview_data?project=PXD035519 To https://www.ebi.ac.uk/pride/ws/archive/crosslinking/data/get_xiview_data?project=PXD035519

colin-combe commented 5 months ago

right, in two places, one for data, one for peaklists, here: https://github.com/PRIDE-Archive/xiview-server/blob/pride/static/network.html#L168-L169

ypriverol commented 5 months ago

Got it. But then this needs to be changed in the xview server not in pride-web.

sureshhewabi commented 5 months ago

ah sorry, I thought both places, but no no need to change from our web. I did a PR @colin-combe

colin-combe commented 5 months ago

I did a PR @colin-combe

i don't see it, where is it?

sureshhewabi commented 5 months ago

https://github.com/Rappsilber-Laboratory/xiview-server/pull/56

sureshhewabi commented 5 months ago

fixed!

colin-combe commented 5 months ago

annotated spectra too?

sureshhewabi commented 5 months ago

@colin-combe ah xiview.js file needs to be changed as well. Could you do a PR for that? current one is compressed version I guess

colin-combe commented 5 months ago

think i must have made a mistake, a bug fix might not have got merged coz xiview.js shouldn't need updated. What are you seeing to think it needs updated?

colin-combe commented 5 months ago

spectra are working, right?

sureshhewabi commented 5 months ago

I am not sure, I remember previously, when we change the URL, we had to change it in xiview.js as well. I could not find the URL this time, so I thought it is because it is compressed.

Can you quickly check if current version published on web is fine? for me it looks fine

Screenshot 2024-02-05 at 11 32 49

colin-combe commented 5 months ago

I am not sure, I remember previously, when we change the URL, we had to change it in xiview.js as well. I could not find the URL this time, so I thought it is because it is compressed.

that was a mistake (url hardcode into the js by mistake), now it takes it from here https://github.com/PRIDE-Archive/xiview-server/blob/pride/static/network.html#L168-L169. (Though window.peakListUrl should be a parameter, not a global variable).

Can you quickly check if current version published on web is fine? for me it looks fine

yes, for me it looks fine too