pagination issue (dataset page)?

PRIDE-Archive / xi-mzidentml-converter

Apache License 2.0

0 stars 0 forks source link

pagination issue (dataset page)? #51

Closed colin-combe closed 4 months ago

colin-combe commented 5 months ago

on whats currently deployed at https://www.ebi.ac.uk/pride/archive/crosslinking/PXD031755 in the protein table, for me, first all the entries are shown in table rather than 20 per page, then if items per page count is changed nothing is shown (using Chrome)

sureshhewabi commented 5 months ago

Related with #50

Pagination information added to API

Eg:``` "page": { "page_no": 1, "page_size": 10, "total_elements": 13, "total_pages": 2, }

shabai517 commented 5 months ago

It is fine for me in the frontend.

colin-combe commented 5 months ago

https://www.ebi.ac.uk/pride/archive/crosslinking/PXD031755 is blank for me, so i can't test it again (api is just down at moment)

colin-combe commented 5 months ago

for me it is broken just like before (https://www.ebi.ac.uk/pride/archive/crosslinking/PXD031755 )

sureshhewabi commented 5 months ago

Colin, it is not fixed in the front end. that comment is there for Bai - frontend developer to fix it. He means he is fine with the API response format

colin-combe commented 5 months ago

ok, sorry

sureshhewabi commented 5 months ago

This should be done now. Please report if there's any issues