PRIDE-Archive / xi-mzidentml-converter

Apache License 2.0
0 stars 0 forks source link

Sync filename keys for the PDB-Dev endpoints #57

Closed aozalevsky closed 4 months ago

aozalevsky commented 4 months ago

Right now sequences endpoint uses identification_file_name for the mzIdentML filename:

{
  'id': 'dbseq_P0A6U8_target', 
  'identification_file_name': 'membrane_5pc_1200IDs.mzid', 
  'sequence': 'M<..>K', 
  'accession': 'P0A6U8'
}

at the same time residue-pairs uses file for the same information:

{
  'id': 'SII_139324_1', 
  'file': 'membrane_5pc_1200IDs.mzid', 
  'pass': True, 
  'prot1': 'dbseq_P0A6U8_target', 
  'pos1': 13, 
  'prot2': 'dbseq_P0A6U8_target', 
  'pos2': 46
}

thus it may be worth syncing the keys for API consistency.

aozalevsky commented 4 months ago

it's not a critical or pressing issue, but rather a feature request or enhancement for the future.

colin-combe commented 4 months ago

yes, you're right. Lets fix

colin-combe commented 4 months ago

@sureshhewabi - lets go for the shorter 'file'?

sureshhewabi commented 4 months ago

sequences endpoint response 'identification_file_name' renamed to 'file'

sureshhewabi commented 4 months ago

Done