PRINCEMAIN / geocoding-net

Automatically exported from code.google.com/p/geocoding-net
0 stars 0 forks source link

"enum GoogleStatusCode" completeness #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Not really a 'defect' but I couldn't open an issue as any other type... ?

Anyway, since we're implementing "enum GoogleStatusCode"... Why don't we
have all possible situations... ? I could extend the current list to:

    public enum GoogleStatusCode
    {
        Success = 200,
        BadRequest = 400,
        ServerError = 500,
        MissingAddress = 601,
        UnknownAddress = 602,
        UnavailableAddress = 603,
        BadKey = 610,
        TooManyQueries =620
    }

Personally, I'm getting my application to throttle if we find a 620... ;)

Original issue reported on code.google.com by exi.m...@gmail.com on 4 Jun 2008 at 6:13

GoogleCodeExporter commented 9 years ago
Sure, could you submit a patch?

Original comment by chadl...@gmail.com on 16 Jul 2008 at 1:53

GoogleCodeExporter commented 9 years ago
This patch fixes the following items:

1. Issue 2 and Issue 8
2. Adds "FormattedAddress" property to Core.Address.
3. Adds an out param for GeoCode to the three geocoders that will return the 
status 
code from the server. There is an overload that will ignore the status code so 
it 
doesnt break any code.

Original comment by shaun%go...@gtempaccount.com on 11 Nov 2009 at 7:10

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Good lord, it would help if I could update the correct file. SORRY EVERYONE!

Original comment by shaun%go...@gtempaccount.com on 11 Nov 2009 at 7:33

Attachments:

GoogleCodeExporter commented 9 years ago
It doesnt look like you ever comitted this patch. Here it is again for just the 
GoogleStatusCode.cs file.

Original comment by google%g...@gtempaccount.com on 23 May 2010 at 1:51

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, applied in r44.

Original comment by chadl...@gmail.com on 24 May 2010 at 3:54

GoogleCodeExporter commented 9 years ago
I'm not seeing this change in the latest download version.

Original comment by johnriss...@gmail.com on 17 Oct 2010 at 2:10