PRIS-CV / DemoFusion

Let us democratise high-resolution generation! (CVPR 2024)
https://ruoyidu.github.io/demofusion/demofusion.html
1.98k stars 229 forks source link

Errata in the paper #28

Closed ttulttul closed 11 months ago

ttulttul commented 11 months ago

Your formula for c1 in the paper is:

c1 = ((1 + cos(2pit / T)) / 2) ** alpha_1

However, in your code, you do not multiply pi by 2. If you use 2*pi in the cosine function, then over the interval of t=[0,T], the cosine function will cause c1 to vary from 1, to 0, and then back to 1 again, which is definitely not what you want.

RuoyiDu commented 11 months ago

Haha yes. Sorry for the mistake I made in my haste, I've spotted this and will fix it in the next version. Thank you for the thoughtful reminder!

ttulttul commented 11 months ago

No worries. It's a really interesting technique you've found. I am working on a ComfyUI-native implementation.