PRJosh / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Don't ignore user set CFLAGS #106

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The attached patch fixes Makefile to not ignore user set CFLAGS but to append 
to them instead.

Original issue reported on code.google.com by vsky...@gmail.com on 5 Jan 2014 at 9:42

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by yann.col...@gmail.com on 5 Jan 2014 at 10:31

GoogleCodeExporter commented 9 years ago
Good point.
Although, as a minor detail, I thought that :

CFLAGS += -I. -std=c99 -Wall -W -Wundef -DLZ4_VERSION=\"$(RELEASE)\"

would do the same thing.

Original comment by yann.col...@gmail.com on 5 Jan 2014 at 10:33

GoogleCodeExporter commented 9 years ago
I think so too, but ISTR the approach in my patch is more portable than +=.

Original comment by vsky...@gmail.com on 5 Jan 2014 at 10:45

GoogleCodeExporter commented 9 years ago
Nevermind, I seem to remember wrong, += is probably better after all :)

Original comment by vsky...@gmail.com on 5 Jan 2014 at 10:50

GoogleCodeExporter commented 9 years ago
OK
The attached file (rc 111) should behave as you ask.

Note that the directory structure has evolved since r110, therefore there are 
now 2 makefiles (but the one at the root can be used to order the one into 
programs, so that simple commands such as make all, make install, make clean, 
still work as before).

Original comment by yann.col...@gmail.com on 6 Jan 2014 at 2:14

Attachments:

GoogleCodeExporter commented 9 years ago
fixed into r111

Original comment by yann.col...@gmail.com on 7 Jan 2014 at 6:53