Makefile: liblz4 target generates dummy shared object

PRJosh / lz4

Automatically exported from code.google.com/p/lz4

0 stars 0 forks source link

Makefile: liblz4 target generates dummy shared object #107

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

The liblz4 target doesn't specify the sources to compile.
This results in the generation of a "dummy" shared library instead of a shared 
library with lz4 symbols exported.

I will attach a patch that fixes this issue.

Original issue reported on code.google.com by radiants...@gmail.com on 8 Jan 2014 at 12:54

Attachments:

02-fix-so-generation.patch

GoogleCodeExporter commented 9 years ago

Sure an important patch, thanks for that

Original comment by yann.col...@gmail.com on 8 Jan 2014 at 1:13

Changed state: Accepted
Added labels: Priority-Medium
Removed labels: Priority-minor

GoogleCodeExporter commented 9 years ago

with proposed correction

Original comment by yann.col...@gmail.com on 8 Jan 2014 at 1:16

Attachments:

lz4-r112.tar.gz

GoogleCodeExporter commented 9 years ago

Tested, works

Original comment by radiants...@gmail.com on 8 Jan 2014 at 1:30

GoogleCodeExporter commented 9 years ago

fixed into r112

Original comment by yann.col...@gmail.com on 8 Jan 2014 at 6:50

Changed state: Fixed