search

PRJosh / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Does not compile under iOS #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
typedef const BYTE* Ptr; in line 172 of lz4.c is causing issues under iOS.

Original issue reported on code.google.com by JJX...@gmail.com on 18 Aug 2013 at 5:01

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
This update for lz4.c fixes the problem by making ptr PCBYTE

Original comment by JJX...@gmail.com on 18 Aug 2013 at 5:05

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks, looks fine.
Is Ptr a reserved keyword under iOS (or Objective C) ?

Original comment by yann.col...@gmail.com on 18 Aug 2013 at 5:29

GoogleCodeExporter commented 9 years ago 
It is yea, in MacTypes.h. I didn't end up liking PCBYTE so I renamed it to 
LZ4PTR.

Original comment by JJX...@gmail.com on 18 Aug 2013 at 5:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Actually, PCBYTE is not that bad, since it invites to read "Pointer Const BYTE".

I also don't like that it sounds "PC" related. But I guess we can find 
something not too far.

Original comment by yann.col...@gmail.com on 18 Aug 2013 at 6:03

GoogleCodeExporter commented 9 years ago 
K. I leave the final name up to you :)

Original comment by JJX...@gmail.com on 18 Aug 2013 at 6:27

GoogleCodeExporter commented 9 years ago

Original comment by yann.col...@gmail.com on 19 Aug 2013 at 2:21

GoogleCodeExporter commented 9 years ago 
Fixed into r103.
I reverted to previous notation (const BYTE*).

Original comment by yann.col...@gmail.com on 9 Sep 2013 at 9:09