Closed pthariensflame closed 1 year ago
@pthariensflame thank you for this.
Apologies, I don't use homebrew so for me it's difficult supporting this so any help or pointers would be appreciated.
Does this mean that for every release of prql-query this needs to be updated? What is that SHA compiled from?
@snth No worries!
The SHA is of the file specified in url
, so it changes as the downloaded file does, naturally. A change like this is needed every release of prql-query
but it doesn't have to be manual; prql-compiler
's formula has been being updated by a GitHub Action, IIUC.
If you'd like, I can add to this PR by formatting and cleaning up the file to Homebrew's intended form. ❤️
Thank you @pthariensflame . That would be amazing!
I cleaned up both formulae and made the GitHub Action enforce style from now on.
Thank you very much @pthariensflame . Are you one of the homebrew maintainers/volunteers? Does this mean prql-query is now part of homebrew core like prql-query or it's still a tap/cask (apologies, I forgot the correct term and difference between the two)?
Also, would you say this is good to merge now?
I'm going to cut a prql-query release soon (today or tomorrow possibly) so we'll probably see soon if it all works.
This is still a separate tap, not “official”! And no, I’m not part of Homebrew, just a knowledgeable volunteer. 😄 Something failed here so I want to investigate that before merging, but it should be good to go soon!
Okay; this should be good to merge as long as the tests pass!
Great, thanks so much!
Because of https://github.com/PRQL/homebrew-prql/issues/11, I'm going to merge and then we can iterate...
Thank you
Created with
brew bump-formula-pr
.