PRQL / homebrew-prql

2 stars 2 forks source link

prql-query v0.0.14 #10

Closed pthariensflame closed 1 year ago

pthariensflame commented 1 year ago

Created with brew bump-formula-pr.

snth commented 1 year ago

@pthariensflame thank you for this.

Apologies, I don't use homebrew so for me it's difficult supporting this so any help or pointers would be appreciated.

Does this mean that for every release of prql-query this needs to be updated? What is that SHA compiled from?

pthariensflame commented 1 year ago

@snth No worries!

The SHA is of the file specified in url, so it changes as the downloaded file does, naturally. A change like this is needed every release of prql-query but it doesn't have to be manual; prql-compiler's formula has been being updated by a GitHub Action, IIUC.

If you'd like, I can add to this PR by formatting and cleaning up the file to Homebrew's intended form. ❤️

snth commented 1 year ago

Thank you @pthariensflame . That would be amazing!

pthariensflame commented 1 year ago

I cleaned up both formulae and made the GitHub Action enforce style from now on.

snth commented 1 year ago

Thank you very much @pthariensflame . Are you one of the homebrew maintainers/volunteers? Does this mean prql-query is now part of homebrew core like prql-query or it's still a tap/cask (apologies, I forgot the correct term and difference between the two)?

Also, would you say this is good to merge now?

I'm going to cut a prql-query release soon (today or tomorrow possibly) so we'll probably see soon if it all works.

pthariensflame commented 1 year ago

This is still a separate tap, not “official”! And no, I’m not part of Homebrew, just a knowledgeable volunteer. 😄 Something failed here so I want to investigate that before merging, but it should be good to go soon!

pthariensflame commented 1 year ago

Okay; this should be good to merge as long as the tests pass!

snth commented 1 year ago

Great, thanks so much!

max-sixty commented 1 year ago

Because of https://github.com/PRQL/homebrew-prql/issues/11, I'm going to merge and then we can iterate...

snth commented 1 year ago

Thank you