search

PRQL / homebrew-prql

2 stars 2 forks source link

Adds Formula and workflows for prql-query #5

Closed snth closed 2 years ago

snth commented 2 years ago

@max-sixty As per your suggestion, trying to see if I can get the homebrew workflow for prql-query working with the existing hombrew tap.

max-sixty commented 2 years ago

@snth It looks like the linux workflow fails: https://github.com/prql/homebrew-prql/actions/runs/3316049427/jobs/5477387112

Should we fix or remove that?

If we want to use brew, we can use a brew-action, which avoids us having to install it ourselves, and might even allow parameterizing a single action over Mac & Linux.

(We can also set it to run on PRs if we want to test it before merging)

snth commented 2 years ago

I'm happy to switch to a brew-action. I don't know much about this space so happy to take any guidance.

If possible I'd like to park the workflow issues for a bit and fix some of the outstanding issues on prql-query. Both are required though for a 0.1 release. Any chance we can rope in some of the original brew contributors to fix this up?

max-sixty commented 2 years ago

Ah, sorry, I thought you added that, my mistake. Let me take a swing at it.

Any chance we can rope in some of the original brew contributors to fix this up?

Open source is a magical way of organizing, but one downside is that roping people in is difficult!

max-sixty commented 2 years ago

I just did something at https://github.com/prql/homebrew-prql/commit/9d8692f33c6c19cd2b39dee49770cbdf143515e2 — I mistakenly pushed to main without a PR. Let's see if that works though.