Closed eitsupi closed 1 year ago
@snth Could you take a look at this? Thanks.
Thanks @eitsupi . Looks good. Just one comment about rather keeping that FIXME as a reminder.
Thank you for your review. I updated that.
@snth Could you take another look at this? Thanks.
Hi, apologies for the delay. I finally got to this. It's looking great!
I see the help output has changed quite a lot with the change from clap 3 to 4 but the new formatting is good and more neutral.
I'm happy with the changes. Thanks very much @eitsupi ! I was just wondering if it would be possible to add the same to the short about because as you pointed out, now the PRQL version only shows up with --help
and not with -h
? If that's not an easy addition then I'm happy to merge as is.
@snth Thanks for your review. Updated to show with -h
.
This has eliminated any difference in content between -h
and --help
other than formatting, so for now, long_about is disabled and both -h
and --help
have the same output.
If the information we want to include only in --help
is needed again, we can add long_about again.
@snth Is there any reason yet why this cannot be merged? Thanks.
No, there isn't and sorry for the holdup. I wanted to test it but I trust that you've done a good job with it.
Compiling things with DuckDB tends to take so long on my machine that I tend to want to batch it along with other tasks such as upgrading the DuckDB and DataFusion versions. I haven't been getting to that part hence I wasn't merging this either.
Happy to merge this now though so that you don't have to worry about it anymore.
Thank you very much for your contribution and apologies again for taking so long on this.
Sorry for rushing you. I too suffered from the slow build of duckdb... Definitely worth adding automated tests.
The version of prql-compiler built into this tool may be a bit backward, so informing users of this may help resolve the issue.
I have found that using clap version 4 makes it easy to embed String in help, so I am trying that.
So far it is only shown in long_about displayed with--help
and the display is simple, but I think I can change it to something better if needed.-> Updated to show on about without using long_about for now.