search

PRQL / prql

PRQL is a modern language for transforming data — a simple, powerful, pipelined SQL replacement
https://prql-lang.org
Apache License 2.0
9.84k stars 216 forks source link

DevContainer doesn't contain `pre-commit` #4548

Closed richb-hanover closed 3 months ago

richb-hanover commented 3 months ago

What's up?

I used Docker Desktop to delete all PRQL containers, volumes, and images, then restarted the DevContainer.

When I used task test-lint I got an error to the effect that pre-commit is not available.

I used pip install pre-commit and all was well: I could run task test-lint without problems.

How could we get pre-commit installed into the base PRQL DevContainer? Thanks.

eitsupi commented 3 months ago

See https://github.com/PRQL/prql/issues/3709#issuecomment-1774100184

To support macOS, it seems impossible.

max-sixty commented 3 months ago

@richb-hanover if anything has changed since we hit the error and installing pre-commit in postCreateCommand works, we can re-enable it...

max-sixty commented 3 months ago

Marking as postponed — it's a problem but there's not much we can do at the moment