fix(prqlc-python): add missing type annotation for pl_to_prql

PRQL / prql

PRQL is a modern language for transforming data — a simple, powerful, pipelined SQL replacement

https://prql-lang.org

Apache License 2.0

9.6k stars 208 forks source link

fix(prqlc-python): add missing type annotation for pl_to_prql #4588

Closed kgutwin closed 3 weeks ago

kgutwin commented 3 weeks ago

Forgot the type annotation for the latest binding. I wonder if it's possible to do an automated check on this...

max-sixty commented 3 weeks ago

Yes we could add a mypy strict confirm...

kgutwin commented 3 weeks ago

That would be a good first step -- although what would have been needed to have caught this flub is cross-checking between the pyo3 output and the .pyi type stub file. Mypy can't check that because it trusts the .pyi type stubs.

It looks like pyo3 is already tracking this over at https://github.com/PyO3/pyo3/issues/2454 ...

max-sixty commented 3 weeks ago

OIC — good point — so mypy checks the static python code. Makes sense.

And I notice we already have strict = true...