search

PRQL / prql

PRQL is a modern language for transforming data — a simple, powerful, pipelined SQL replacement
https://prql-lang.org
Apache License 2.0
9.58k stars 208 forks source link

refactor: Split up giant `expr` func in parser #4653

Closed max-sixty closed 1 week ago

max-sixty commented 1 week ago

Renames Indirection to Property, which seems like a more familiar name

max-sixty commented 1 week ago

An alternative could be "FieldDereference" or "FieldLookup".

Perfect — going with FieldLookup. (Indirection sounded a bit like a magician :) )

aljazerzen commented 1 week ago

Oh no, I've doubled-down on name indirection on my branch - is there an option to reconsider this change?

Indirection is real compiler terminology, I'm not making this up!

max-sixty commented 1 week ago

Indirection is real compiler terminology, I'm not making this up!

Totally fine to revert if it helps keep the code moving.

(I'm v familiar with the concept of indirection; I don't think it's a clear description for an AST item, but this is very minor, revert away...)