Closed dependabot[bot] closed 1 week ago
@aljazerzen not important for PRQL (and not confident on the rust standards) — but to the extent that connector_arrow
is fairly bound to the arrow version, you could re-export arrow from there, so downstream libraries won't get conflicts between their version of arrow vs. connector_arrow's version of arrow...
That might be a good idea, yes. So they don't need to depend on arrow themselves (ourselves in this case).
It turns out I already do, but but we need to depend on arrow
anyways, because we need additional features that are not needed for connector_arrow
.
Additionally, I now realize that updating arrow version in connector_arrow is a breaking change, as it is exposed in the public API. Which also means that the crazy release cadence of arrow-rs is also forced on connector_arrow.
Is connector_arrow
used anywhere other than Lutra? Can you not isolate the arrow dependency to the Lutra crate?
You mentioned you also use arrow
elsewhere and I guess the playground would be one place. Anywhere else?
In my experience that arrow release cadence can really cause headaches and cause a lot of conflicts so if it's included in the main compiler or parser crate, that could cause issues for people wanting to use that crate.
Yes, arrow is directly used only in lutra (and even there we could use the re-export from connector_arrow).
It is also present as a transitive dependency via duckdb, which we use in integration tests in prqlc.
arrow v51.0.0
├── connector_arrow v0.4.2
│ └── lutra v0.12.3 (/home/aljaz/Projects/prql/lutra/lutra)
│ └── lutra-python v0.12.3 (/home/aljaz/Projects/prql/lutra/bindings/python)
├── lutra v0.12.3 (/home/aljaz/Projects/prql/lutra/lutra) (*)
├── lutra-python v0.12.3 (/home/aljaz/Projects/prql/lutra/bindings/python)
└── duckdb v0.10.2
└── prqlc v0.12.3 (/home/aljaz/Projects/prql/prqlc/prqlc)
Bumps the patch group with 3 updates: syn, strum and connector_arrow.
Updates
syn
from 2.0.66 to 2.0.68Release notes
Sourced from syn's releases.
Commits
ecb0429
Release 2.0.6837edbd2
Merge pull request #1690 from stepancheg/track-called4338772
track-caller in parse_quote_spanned537b0c5
Update test suite to nightly-2024-06-22b088d5c
Merge pull request #1688 from dtolnay/peeklit9b4e478
Relocate Lit peek impls into lit module38f2ddb
Merge pull request #1687 from dtolnay/fastpeekef20bfd
Optimize the peek impl of Group and Lifetime4b6c96a
Merge pull request #1686 from dtolnay/isempty87d5792
Reword explanation of ParseBuffer::is_emptyUpdates
strum
from 0.26.2 to 0.26.3Release notes
Sourced from strum's releases.
Changelog
Sourced from strum's changelog.
Commits
c89286f
Update changelog & strum_macros version0c85c16
Use associated function syntax for callingget
on anEnumIter
, eliminatin...9689d7b
add hyperlinks to documentation and clarify derive macros (#355)186d29f
Interpolate unnamed enum variant fields in to_string attribute (#345)410062e
Fix broken links (#350)1e46337
Updateheck
requirement (#346)f5fce03
Fix typos & misspellings in docs (#347)Updates
connector_arrow
from 0.4.1 to 0.4.2Commits
b2f24ef
build: release8f8fb1f
build(deps): update rstest requirement from 0.19.0 to 0.21.03776891
remove Cargo.lock9f1ed89
---fb4c79d
build: remove Cargo.lock, update arrowecc8761
build: bump rstest from 0.18.2 to 0.19.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show