PRQL / prqlc-r

R Bindings for prqlc
https://prql.github.io/prqlc-r/
Other
56 stars 2 forks source link

chore: bump savvy from 0.2.16 to 0.2.17 in /src/rust #274

Closed dependabot[bot] closed 7 months ago

dependabot[bot] commented 7 months ago

Bumps savvy from 0.2.16 to 0.2.17.

Changelog

Sourced from savvy's changelog.

[v0.2.17] (2024-03-10)

Breaking changes

  • get_dim() now returns &[i32] instead of Vec<usize> to avoid allocation. If the matrix library requires usize, you need to convert the i32 to usize by yourself now. Accordingly, set_dim() now accepts both &[i32] and &[usize].
Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
eitsupi commented 7 months ago

@yutannihilation Sorry to tag you, but are these compile errors problems that can be fixed in this repository?

   Compiling savvy-macro v0.2.9
error[E0308]: mismatched types
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/savvy-0.2.17/src/sexp/mod.rs:83:34
    |
83  |             let c = Rf_type2char(TYPEOF(self.0));
    |                     ------------ ^^^^^^^^^^^^^^ expected `u32`, found `i32`
    |                     |
    |                     arguments to this function are incorrect
    |
note: function defined here
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/savvy-ffi-0.2.9/src/lib.rs:173:12
    |
173 |     pub fn Rf_type2char(arg1: SEXPTYPE) -> *const ::std::os::raw::c_char;
    |            ^^^^^^^^^^^^
help: you can convert an `i32` to a `u32` and panic if the converted value doesn't fit
    |
83  |             let c = Rf_type2char(TYPEOF(self.0).try_into().unwrap());
    |                                                ++++++++++++++++++++

error[E0308]: mismatched types
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/savvy-0.2.17/src/sexp/mod.rs:257:37
    |
257 |     if unsafe { TYPEOF(dim_sexp) != savvy_ffi::INTSXP } {
    |                 ----------------    ^^^^^^^^^^^^^^^^^ expected `i32`, found `u32`
    |                 |
    |                 expected because this is `i32`
    |
help: you can convert a `u32` to an `i32` and panic if the converted value doesn't fit
    |
257 |     if unsafe { TYPEOF(dim_sexp) != savvy_ffi::INTSXP.try_into().unwrap() } {
    |                                                      ++++++++++++++++++++

For more information about this error, try `rustc --explain E0308`.
error: could not compile `savvy` (lib) due to 2 previous errors
yutannihilation commented 7 months ago

Ah, you need to update savvy_ffi as well. Sorry that the version requirement is not strict.

eitsupi commented 7 months ago

I see, thanks for quick reply!

dependabot[bot] commented 7 months ago

Superseded by #275.