search

PRUNERS / FLiT

A project to quickly detect discrepancies in floating point computation across hardware, compilers, libraries and software.
Other
36 stars 6 forks source link

Issue172 bisect in order #197

Closed mikebentley15 closed 6 years ago

mikebentley15 commented 6 years ago

Fixes issue #172.

Adds the --biggest flag to flit bisect. It allows the search for only the top k contributing functions.

Testing: This pull request adds additional testing for FLiT Bisect, specifically for the bisect biggest functionality. This adds about 5 seconds to the runtime of the tests.

Documentation: not yet, but should be added before this pull request completes.

Even though the pull request is missing documentation, I figured we could get started on the code review before the documentation is in place. That way, the documentation can be added while the code review is underway.

mikebentley15 commented 6 years ago

Three issues that Ian has mentioned to me personally:

  1. using python's implicit conversion of list to bool in the python code (maybe it's pythonic, but hard to read for those not fully committed to the "pythonic" way) I fully agree and they should be changed to len(<list>) > 0. This I will fix in this pull request
  2. The flit_bisect.py file is getting too large at around 1800 lines. I made a new issue to track this, #198
  3. This change has not been documented. I made a new issue to track this, #199

After I fix number 1, I hope Ian is happy with this pull request, after he finishes the review of course :smile: