search

PRUNERS / FLiT

A project to quickly detect discrepancies in floating point computation across hardware, compilers, libraries and software.
Other
36 stars 6 forks source link

When `flit init --litmus-tests` is used, do not copy `Empty.cpp` #316

Closed mikebentley15 closed 4 years ago

mikebentley15 commented 4 years ago

Bug Report

Describe the problem When the user calls flit init --litmus-tests, they are likely wanting to just run the litmus tests, or use them as an example for writing their own tests.

In the first case, the user will not want the Empty.cpp test case in their list of tests since that is misleading, even if the test case is disabled when generating output.

In the second case, the user may or may not want Empty.cpp as a basis for creating their own test. I would say it is sufficient for them to look at the litmus tests as examples for how to write their own tests and Empty.cpp is unnecessary.

Suggested Fix If the --litmus-tests option is used for flit init, then do not include Empty.cpp in the list of files to copy over.

I am not sure if documentation needs to be updated anywhere. I do not know if this functionality is currently documented.

mikebentley15 commented 4 years ago

I think this is a good first issue for John to take. It involves

  1. Creating a test that fails until the new functionality is implemented in tests/flit_cli/flit_init/
  2. Implement the change in scripts/flitcli/flit_init.py until the created test passes
  3. Make sure all other tests continue to pass
  4. Checking documentation to see if it needs updating

I would be happy to work with John or review his work. Whatever works for John.

JohnJacobsonIII commented 4 years ago

Affirmative. I will work on this, and will reach out if I have any questions.

Thanks!

John

On Tue, Jan 21, 2020, 12:01 Michael Bentley notifications@github.com wrote:

I think this is a good first issue for John to take. It involves

  1. Creating a test that fails until the new functionality is implemented in tests/flit_cli/flit_init/
  2. Implement the change in scripts/flitcli/flit_init.py until the created test passes
  3. Make sure all other tests continue to pass
  4. Checking documentation to see if it needs updating

I would be happy to work with John or review his work. Whatever works for John.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/PRUNERS/FLiT/issues/316?email_source=notifications&email_token=AOKR56SMII5BX24W5LFI653Q65BA7A5CNFSM4KJYM4VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQ3SFA#issuecomment-576829716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOKR56R6QOJE7Z2ZU7L2DXDQ65BA7ANCNFSM4KJYM4VA .