search

PRUNERS / FLiT

A project to quickly detect discrepancies in floating point computation across hardware, compilers, libraries and software.
Other
36 stars 6 forks source link

Issue121 bash completion #319

Closed mikebentley15 closed 4 years ago

mikebentley15 commented 4 years ago

Fixes #121

Description: Added a bash-completion script for the flit command-line tool

Documentation:

Tests: I added the test tests/flit_cli/bash_completion/tst_completion_flit.py. This file will take the argparse.ArgumentParser instance from flit.py and automatically check that all subcommands and options are completed using bash-completion.

This test took a lot of time to make to introspect from the argparse python module. The goal here was to make a test that fails if a new flag is added to one of the flit subcommands, but is not added to the bash-completion script.

mikebentley15 commented 4 years ago

@JohnJacobsonIII How is your review of the bash-completion pull request coming?

JohnJacobsonIII commented 4 years ago

Will do my best to complete tonight, apologies

On Tue, Mar 3, 2020, 17:17 Michael Bentley notifications@github.com wrote:

@JohnJacobsonIII https://github.com/JohnJacobsonIII How is your review of the bash-completion pull request coming?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PRUNERS/FLiT/pull/319?email_source=notifications&email_token=AOKR56QL536WEDOUNLBJP2LRFWMYNA5CNFSM4KYCKQ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVV4OY#issuecomment-594239035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOKR56VCVVRA2PWLB5WKJIDRFWMYNANCNFSM4KYCKQ4A .

mikebentley15 commented 4 years ago

@JohnJacobsonIII Any progress on this? I'm waiting on these two pull requests before I create a FLiT release. If you're having trouble, I'm happy to help. We could do a Google Hangout or something. Or if you have questions, you can post them here, or put them in the code review for me to answer.