search

PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
62 stars 13 forks source link

Update InstrumentParallel.cpp #19

Closed simoatze closed 7 years ago

simoatze commented 7 years ago

Added suppression in "__tsan_default_suppressions" function inserted by the instrumentation pass (Resolve #21).

dongahn commented 7 years ago

@simoatze: is there an issue ticket for this problem? If so, it would be good to list it here gor better tracking. If not, could yoi create a short one, thulis will help review this PR.

simoatze commented 7 years ago

@dongahn Joachim added the suppression in the suppression file, I was just adding the same in the function that is inserted at instrumentation time, so we don't need to specify the explicitly the suppression file with the env var TSAN_OPTION. I didn't open an issue because it was just an integration. Do you want me to open it?

dongahn commented 7 years ago

@simoatze: thanks. Yes, please copy and paste your comment into a new new issue and refer it in this PR. This way, if someone other than us can trace back the topic of this PR when they look at the commit message. Also, if you have "Resolve #N" in your PR message body (where N is the issue ticket number), merging your PR will automatically close that issue. Thanks.

dongahn commented 7 years ago

LGTM. Since this is @jprotze 's branch, i will let him review this and merge if ok.