search

PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
62 stars 13 forks source link

Update README.md #2

Closed mknobi closed 7 years ago

mknobi commented 7 years ago

Added correct directory change

dongahn commented 7 years ago

This looks ok. @simoatze: do you want me to merge this? Once this is merged, I will rebase my other pull.

simoatze commented 7 years ago

@dong Yes thanks! and then we can merge your pull request.

dongahn commented 7 years ago

@simoatze: do you want me to remove README.org as part of this PR as well?

simoatze commented 7 years ago

Yes please! Thanks @dongahn

dongahn commented 7 years ago

@simoatze, I thought you wanted me to incorporate REAME.org removal into this PR... I will do a separate PR for that one. In general, it should always help to have all the relevant changes into a single commit/PR in case others need to keep track of the change history better. Just FYI for future commits/PRs.

simoatze commented 7 years ago

Sorry @dongahn for some reasons I thought the change was already there.

dongahn commented 7 years ago

Not a problem!

BTW, there was another PR. Was that merged as well?

We probably need to make sure one of my PRs did not override the change made from the previous PR...

My preference would be to have some committer protocol to avoid such situations.

When the committer (@simoatze you in this case) merges a PR in, he/she let the other PR provider to know there was a new merge so that the provider need to rebase the local branch from which the PR came from against upstream/master.

Does it make sense?

simoatze commented 7 years ago

Yeah it does, but I didn't change anything because in this pull request the cmake command was in one line while I usually put every parameter in a new line with a '\' so we won't pass 80 characters.

dongahn commented 7 years ago

Got it! Thanks.

Please consider my above comments just as a future reference :-)

simoatze commented 7 years ago

@dongahn Sounds good! I think all is good now, and Travis CI is passing the test.